PMD Results

The following document contains the results of PMD 5.2.3.

Files

jgloss/JGlossApp.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 66
Singleton is not thread safe 78–80
Potential violation of Law of Demeter (method chain calls) 79
Potential violation of Law of Demeter (object not created locally) 100
Potential violation of Law of Demeter (object not created locally) 103
Potential violation of Law of Demeter (static property access) 115
A method/constructor shouldnt explicitly throw java.lang.Exception 127
Consider using varargs for methods or constructors which take an array the last parameter. 127
Potential violation of Law of Demeter (object not created locally) 142
Potential violation of Law of Demeter (object not created locally) 145
Potential violation of Law of Demeter (method chain calls) 169

jgloss/ui/annotation/Annotation.java

Violation Line
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_owner' is not final. 64
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_anno' is not final. 64
Potential violation of Law of Demeter (method chain calls) 107
Potential violation of Law of Demeter (method chain calls) 117–118
Potential violation of Law of Demeter (method chain calls) 128
Potential violation of Law of Demeter (method chain calls) 140
Potential violation of Law of Demeter (method chain calls) 140
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_translation' is not final. 147
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_reading' is not final. 153
Avoid using Literals in Conditional Statements 161
Potential violation of Law of Demeter (method chain calls) 163
Potential violation of Law of Demeter (method chain calls) 163
Potential violation of Law of Demeter (method chain calls) 163
Potential violation of Law of Demeter (method chain calls) 168–169
Potential violation of Law of Demeter (method chain calls) 168–169
Potential violation of Law of Demeter (method chain calls) 168–169
Potential violation of Law of Demeter (method chain calls) 168–169
Potential violation of Law of Demeter (method chain calls) 168–169
Potential violation of Law of Demeter (method chain calls) 169
Potential violation of Law of Demeter (method chain calls) 169
Potential violation of Law of Demeter (method chain calls) 176
Potential violation of Law of Demeter (method chain calls) 176
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_reading' is not final. 188
Potential violation of Law of Demeter (method chain calls) 189
Potential violation of Law of Demeter (method chain calls) 189
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_dictionaryForm' is not final. 194
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_dictionaryFormReading' is not final. 204
Potential violation of Law of Demeter (method chain calls) 215–216
Potential violation of Law of Demeter (object not created locally) 222
Potential violation of Law of Demeter (object not created locally) 223
Potential violation of Law of Demeter (object not created locally) 224
Potential violation of Law of Demeter (object not created locally) 226
Potential violation of Law of Demeter (object not created locally) 228
Potential violation of Law of Demeter (object not created locally) 231
Potential violation of Law of Demeter (object not created locally) 233
Potential violation of Law of Demeter (object not created locally) 236
Potential violation of Law of Demeter (object not created locally) 245
Potential violation of Law of Demeter (object not created locally) 252

jgloss/ui/annotation/AnnotationEvent.java

Violation Line
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_index' is not final. 42
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_annotation' is not final. 42
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_source' is not final. 42
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_readingIndex' is not final. 46
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_source' is not final. 46
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_index' is not final. 46
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_annotation' is not final. 46

jgloss/ui/annotation/AnnotationListModel.java

Violation Line
The class 'AnnotationListModel' has a Standard Cyclomatic Complexity of 3 (Highest = 14). 36–249
The class 'AnnotationListModel' has a Modified Cyclomatic Complexity of 3 (Highest = 10). 36–249
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_annoElements' is not final. 54
The method 'findAnnotationIndex' has a Modified Cyclomatic Complexity of 10. 84–147
The method 'findAnnotationIndex' has a Standard Cyclomatic Complexity of 14. 84–147
Potential violation of Law of Demeter (object not created locally) 103
Potential violation of Law of Demeter (method chain calls) 105
Potential violation of Law of Demeter (object not created locally) 122
Potential violation of Law of Demeter (method chain calls) 124–125
Potential violation of Law of Demeter (method chain calls) 182
Potential violation of Law of Demeter (method chain calls) 184
Potential violation of Law of Demeter (method chain calls) 184
Potential violation of Law of Demeter (method chain calls) 190
Potential violation of Law of Demeter (method chain calls) 194
Potential violation of Law of Demeter (method chain calls) 196
Potential violation of Law of Demeter (method chain calls) 196
Potential violation of Law of Demeter (method chain calls) 202
Potential violation of Law of Demeter (object not created locally) 210

jgloss/ui/export/BooleanParameter.java

Violation Line
Potential violation of Law of Demeter (static property access) 53
Potential violation of Law of Demeter (method chain calls) 53
Potential violation of Law of Demeter (method chain calls) 53

jgloss/ui/export/ConstantParameter.java

Violation Line
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_value' is not final. 36
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_name' is not final. 36

jgloss/ui/export/DOMTextEscaper.java

Violation Line
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_escaper' is not final. 50
Potential violation of Law of Demeter (object not created locally) 67
Potential violation of Law of Demeter (object not created locally) 67
Potential violation of Law of Demeter (object not created locally) 73
Potential violation of Law of Demeter (object not created locally) 74
Potential violation of Law of Demeter (object not created locally) 75
Potential violation of Law of Demeter (object not created locally) 75
Potential violation of Law of Demeter (object not created locally) 81
Potential violation of Law of Demeter (object not created locally) 82

jgloss/ui/export/EncodingParameter.java

Violation Line
Potential violation of Law of Demeter (method chain calls) 62
Potential violation of Law of Demeter (static property access) 67

jgloss/ui/export/ExportConfiguration.java

Violation Line
An Interface should be used only to model a behaviour; consider converting this to a class. 61–70
An Interface should be used only to model a behaviour; consider converting this to a class. 75–83
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 88
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 92
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 96
Potential violation of Law of Demeter (static property access) 106
Potential violation of Law of Demeter (static property access) 107
Potential violation of Law of Demeter (method chain calls) 108–110
Potential violation of Law of Demeter (method chain calls) 108–110
Variables that are final and static should be all capitals, 'docFactory' is not all capitals. 119
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 119
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 130
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 131
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 132
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 133
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 134
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 135
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 136
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 137
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_config' is not final. 142
Potential violation of Law of Demeter (method chain calls) 186
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 187
Potential violation of Law of Demeter (static property access) 198
Potential violation of Law of Demeter (static property access) 204
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_parameters' is not final. 208
Potential violation of Law of Demeter (object not created locally) 212
Potential violation of Law of Demeter (object not created locally) 219
Avoid unused method parameters such as 'localizedStrings'. 223
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_template' is not final. 226
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_systemId' is not final. 226
Potential violation of Law of Demeter (method chain calls) 233

jgloss/ui/export/ExportFileChooser.java

Violation Line
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_uiparameters' is not final. 56
Potential violation of Law of Demeter (method chain calls) 108
Potential violation of Law of Demeter (method chain calls) 108
Potential violation of Law of Demeter (method chain calls) 108

jgloss/ui/export/ExportMenu.java

Violation Line
Use block level rather than method level synchronization 63–66
Avoid prefixing parameters by in, out or inOut. Uses Javadoc to document this behavior. 63
Use block level rather than method level synchronization 73–83
Potential violation of Law of Demeter (method chain calls) 74
Potential violation of Law of Demeter (static property access) 74
Potential violation of Law of Demeter (method chain calls) 77–78
Potential violation of Law of Demeter (method chain calls) 77–78
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 79
There is log block not surrounded by if 80
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 85
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_context' is not final. 109
Potential violation of Law of Demeter (method chain calls) 114
Potential violation of Law of Demeter (object not created locally) 125
Potential violation of Law of Demeter (object not created locally) 126–127
Potential violation of Law of Demeter (method chain calls) 126
Potential violation of Law of Demeter (method chain calls) 126–127
Potential violation of Law of Demeter (method chain calls) 126–127

jgloss/ui/export/ListParameter.java

Violation Line
It is somewhat confusing to have a field name matching the declaring class name 52
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_value' is not final. 54
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_label' is not final. 54
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_label' is not final. 60
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_value' is not final. 62
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 68
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 69
Potential violation of Law of Demeter (method chain calls) 93
Potential violation of Law of Demeter (object not created locally) 95
Potential violation of Law of Demeter (static property access) 103
Potential violation of Law of Demeter (object not created locally) 107
Potential violation of Law of Demeter (object not created locally) 108
Potential violation of Law of Demeter (method chain calls) 108
Potential violation of Law of Demeter (method chain calls) 108
Potential violation of Law of Demeter (object not created locally) 108
Avoid using implementation types like 'Vector'; use the interface instead 123
Use ArrayList instead of Vector 124
Potential violation of Law of Demeter (object not created locally) 129
Potential violation of Law of Demeter (object not created locally) 130
Potential violation of Law of Demeter (method chain calls) 131
Potential violation of Law of Demeter (object not created locally) 132
Potential violation of Law of Demeter (method chain calls) 132
Potential violation of Law of Demeter (static property access) 133
Potential violation of Law of Demeter (object not created locally) 137
Potential violation of Law of Demeter (object not created locally) 139
Potential violation of Law of Demeter (method chain calls) 140
Potential violation of Law of Demeter (object not created locally) 145

jgloss/ui/export/LongestAnnotationParameter.java

Violation Line
New exception is thrown in catch block, original stack trace may be lost 54
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 61
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 68
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 70
Potential violation of Law of Demeter (object not created locally) 103
Potential violation of Law of Demeter (object not created locally) 104
Potential violation of Law of Demeter (object not created locally) 105
Potential violation of Law of Demeter (object not created locally) 105

jgloss/ui/export/ParameterFactory.java

Violation Line
An Interface should be used only to model a behaviour; consider converting this to a class. 37–45
Avoid modifiers which are implied by the context 37–45
An Interface should be used only to model a behaviour; consider converting this to a class. 50–52
Avoid modifiers which are implied by the context 50–52
Avoid modifiers which are implied by the context 57–63
An Interface should be used only to model a behaviour; consider converting this to a class. 57–63
Potential violation of Law of Demeter (object not created locally) 76
Potential violation of Law of Demeter (object not created locally) 78
Potential violation of Law of Demeter (object not created locally) 80
Potential violation of Law of Demeter (object not created locally) 82
Potential violation of Law of Demeter (object not created locally) 84
Potential violation of Law of Demeter (object not created locally) 86
Potential violation of Law of Demeter (object not created locally) 88

jgloss/ui/export/StringParameter.java

Violation Line
Potential violation of Law of Demeter (static property access) 59

jgloss/ui/export/UIParameter.java

Violation Line
Potential violation of Law of Demeter (static property access) 68
Potential violation of Law of Demeter (static property access) 78

jgloss/ui/export/XSLTExporter.java

Violation Line
Variables that are final and static should be all capitals, 'transformerFactory' is not all capitals. 63
Potential violation of Law of Demeter (object not created locally) 98
Potential violation of Law of Demeter (method chain calls) 105
Potential violation of Law of Demeter (method chain calls) 111
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 131
Potential violation of Law of Demeter (method chain calls) 136
Potential violation of Law of Demeter (static property access) 138
Avoid prefixing parameters by in, out or inOut. Uses Javadoc to document this behavior. 155
Potential violation of Law of Demeter (method chain calls) 159–160

jgloss/ui/gloss/AnnotationEditorPanel.java

Violation Line
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_annotation' is not final. 160
Use equals() to compare object references. 161
Potential violation of Law of Demeter (object not created locally) 176
Potential violation of Law of Demeter (object not created locally) 184
Potential violation of Law of Demeter (object not created locally) 192
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_enabled' is not final. 220

jgloss/ui/gloss/AnnotationList.java

Violation Line
Possible God class (WMC=52, ATFD=46, TCC=0.003952569169960474) 23–452
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 102
Potential violation of Law of Demeter (object not created locally) 111
Potential violation of Law of Demeter (method chain calls) 111
It is somewhat confusing to have a field name matching the declaring class name 120
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 120
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 125
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 129
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 134
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 138
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 142
Potential violation of Law of Demeter (object not created locally) 189
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_model' is not final. 252
Potential violation of Law of Demeter (method chain calls) 351
Potential violation of Law of Demeter (method chain calls) 351
Potential violation of Law of Demeter (method chain calls) 363
Potential violation of Law of Demeter (method chain calls) 363
Potential violation of Law of Demeter (method chain calls) 398–399
Potential violation of Law of Demeter (method chain calls) 400
Potential violation of Law of Demeter (object not created locally) 400
Potential violation of Law of Demeter (object not created locally) 400
Potential violation of Law of Demeter (method chain calls) 404
Potential violation of Law of Demeter (method chain calls) 404
Potential violation of Law of Demeter (object not created locally) 419
Potential violation of Law of Demeter (object not created locally) 420
Potential violation of Law of Demeter (object not created locally) 425
Potential violation of Law of Demeter (object not created locally) 426
These nested if statements could be combined 426–431
Potential violation of Law of Demeter (object not created locally) 427
Potential violation of Law of Demeter (object not created locally) 428
Potential violation of Law of Demeter (object not created locally) 429
Potential violation of Law of Demeter (object not created locally) 437
Potential violation of Law of Demeter (object not created locally) 438
Potential violation of Law of Demeter (object not created locally) 439
Potential violation of Law of Demeter (method chain calls) 445
Potential violation of Law of Demeter (object not created locally) 445
Potential violation of Law of Demeter (object not created locally) 448

jgloss/ui/gloss/AnnotationListModelAdapter.java

Violation Line
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_annotations' is not final. 41

jgloss/ui/gloss/DocumentActions.java

Violation Line
Potential violation of Law of Demeter (method chain calls) 86

jgloss/ui/gloss/DocumentStyleDialog.java

Violation Line
Too many fields 61–503
The class 'DocumentStyleDialog' has a Modified Cyclomatic Complexity of 3 (Highest = 12). 61–503
The class 'DocumentStyleDialog' has a Standard Cyclomatic Complexity of 3 (Highest = 12). 61–503
Singleton is not thread safe 77–79
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 86
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 88
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 89
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 90
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 92
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 93
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 94
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 96
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 97
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 98
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 100
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 101
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 102
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 103
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 109
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 114
Consider using varargs for methods or constructors which take an array the last parameter. 122
Avoid really long methods. 122–262
The method insertAdditionalControls() has an NCSS line count of 105 122–262
Potential violation of Law of Demeter (static property access) 133
Potential violation of Law of Demeter (static property access) 135
Potential violation of Law of Demeter (static property access) 137–138
Potential violation of Law of Demeter (static property access) 154
Potential violation of Law of Demeter (static property access) 161
Potential violation of Law of Demeter (static property access) 168
Potential violation of Law of Demeter (static property access) 182–183
Potential violation of Law of Demeter (static property access) 186
Potential violation of Law of Demeter (static property access) 190
Potential violation of Law of Demeter (static property access) 206–207
Potential violation of Law of Demeter (static property access) 210
Potential violation of Law of Demeter (static property access) 214
Potential violation of Law of Demeter (static property access) 230–231
Potential violation of Law of Demeter (static property access) 234
Potential violation of Law of Demeter (static property access) 238
Potential violation of Law of Demeter (static property access) 255
Potential violation of Law of Demeter (static property access) 299
Potential violation of Law of Demeter (static property access) 300
Potential violation of Law of Demeter (static property access) 301
Potential violation of Law of Demeter (static property access) 304
Potential violation of Law of Demeter (static property access) 306
Potential violation of Law of Demeter (static property access) 308
Potential violation of Law of Demeter (static property access) 310
Potential violation of Law of Demeter (static property access) 311
Potential violation of Law of Demeter (static property access) 312–313
Potential violation of Law of Demeter (static property access) 316
Potential violation of Law of Demeter (static property access) 318
Potential violation of Law of Demeter (static property access) 320
Potential violation of Law of Demeter (static property access) 322
Potential violation of Law of Demeter (static property access) 331
Potential violation of Law of Demeter (static property access) 335
Potential violation of Law of Demeter (static property access) 339
Potential violation of Law of Demeter (static property access) 345
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 346
Potential violation of Law of Demeter (object not created locally) 347
Potential violation of Law of Demeter (static property access) 348
Potential violation of Law of Demeter (static property access) 353
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 354
Potential violation of Law of Demeter (object not created locally) 355
Potential violation of Law of Demeter (static property access) 356
Potential violation of Law of Demeter (static property access) 361
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 362
Potential violation of Law of Demeter (object not created locally) 363
Potential violation of Law of Demeter (static property access) 364
Potential violation of Law of Demeter (static property access) 367
Potential violation of Law of Demeter (method chain calls) 368
Potential violation of Law of Demeter (static property access) 369
Potential violation of Law of Demeter (object not created locally) 369
Potential violation of Law of Demeter (static property access) 370
Potential violation of Law of Demeter (method chain calls) 371
Potential violation of Law of Demeter (object not created locally) 372
Potential violation of Law of Demeter (static property access) 372
Potential violation of Law of Demeter (static property access) 373
Potential violation of Law of Demeter (method chain calls) 374
Potential violation of Law of Demeter (static property access) 375
Potential violation of Law of Demeter (object not created locally) 375
Potential violation of Law of Demeter (method chain calls) 376
Potential violation of Law of Demeter (object not created locally) 377
Potential violation of Law of Demeter (static property access) 377
Use equals() to compare object references. 400
Potential violation of Law of Demeter (method chain calls) 406–408
Potential violation of Law of Demeter (static property access) 407
Potential violation of Law of Demeter (method chain calls) 408
Potential violation of Law of Demeter (method chain calls) 410
The method 'applyPreferences' has a Modified Cyclomatic Complexity of 12. 420–489
The method 'applyPreferences' has a Standard Cyclomatic Complexity of 12. 420–489
Potential violation of Law of Demeter (static property access) 426
Potential violation of Law of Demeter (method chain calls) 426
Prefer StringBuffer over += for concatenating strings 427
Potential violation of Law of Demeter (static property access) 427
Potential violation of Law of Demeter (static property access) 430
Prefer StringBuffer over += for concatenating strings 431
Prefer StringBuffer over += for concatenating strings 433
The String literal "}\n" appears 4 times in this file; the first occurrence is on line 433 433
Potential violation of Law of Demeter (static property access) 435
Prefer StringBuffer over += for concatenating strings 435
Potential violation of Law of Demeter (static property access) 436
Prefer StringBuffer over += for concatenating strings 437
Potential violation of Law of Demeter (static property access) 438
Potential violation of Law of Demeter (static property access) 442
Prefer StringBuffer over += for concatenating strings 444
Prefer StringBuffer over += for concatenating strings 446
Potential violation of Law of Demeter (static property access) 446
Potential violation of Law of Demeter (static property access) 447
Potential violation of Law of Demeter (method chain calls) 447
Potential violation of Law of Demeter (static property access) 448
Prefer StringBuffer over += for concatenating strings 448
Potential violation of Law of Demeter (static property access) 451
Prefer StringBuffer over += for concatenating strings 452
Potential violation of Law of Demeter (static property access) 454
Prefer StringBuffer over += for concatenating strings 455
Potential violation of Law of Demeter (static property access) 456
Prefer StringBuffer over += for concatenating strings 459
Prefer StringBuffer over += for concatenating strings 461
Potential violation of Law of Demeter (static property access) 463
Prefer StringBuffer over += for concatenating strings 463
Potential violation of Law of Demeter (method chain calls) 464
Potential violation of Law of Demeter (static property access) 464
Prefer StringBuffer over += for concatenating strings 465
Potential violation of Law of Demeter (static property access) 465
Potential violation of Law of Demeter (static property access) 468
Prefer StringBuffer over += for concatenating strings 469
Potential violation of Law of Demeter (static property access) 471
Prefer StringBuffer over += for concatenating strings 472
Potential violation of Law of Demeter (static property access) 473
Prefer StringBuffer over += for concatenating strings 476
Prefer StringBuffer over += for concatenating strings 479
Potential violation of Law of Demeter (object not created locally) 481
Potential violation of Law of Demeter (static property access) 487–488

jgloss/ui/gloss/EmptyDocumentActionsPanel.java

Violation Line
Non-static initializers are confusing 35–37
Potential violation of Law of Demeter (method chain calls) 41

jgloss/ui/gloss/ImportClipboardListener.java

Violation Line
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_importClipboard' is not final. 44

jgloss/ui/gloss/ImportClipboardStrategy.java

Violation Line
Potential violation of Law of Demeter (method chain calls) 60
Potential violation of Law of Demeter (method chain calls) 60
Avoid using Literals in Conditional Statements 68

jgloss/ui/gloss/ImportDocumentAction.java

Violation Line
Potential violation of Law of Demeter (method chain calls) 76
Potential violation of Law of Demeter (method chain calls) 76–77

jgloss/ui/gloss/ImportDocumentStrategy.java

Violation Line
Potential violation of Law of Demeter (object not created locally) 84
Potential violation of Law of Demeter (object not created locally) 85
Potential violation of Law of Demeter (object not created locally) 86
Potential violation of Law of Demeter (object not created locally) 87
Potential violation of Law of Demeter (object not created locally) 88
Potential violation of Law of Demeter (object not created locally) 95
Potential violation of Law of Demeter (object not created locally) 97

jgloss/ui/gloss/ImportFromReaderWorker.java

Violation Line
Perhaps 'length' could be replaced by a local variable. 65
Avoid unused private fields such as 'length'. 65
There is log block not surrounded by if 97
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 109
Potential violation of Law of Demeter (method chain calls) 111–115
Potential violation of Law of Demeter (static property access) 112–113
Potential violation of Law of Demeter (method chain calls) 112–113
Potential violation of Law of Demeter (method chain calls) 113
Potential violation of Law of Demeter (static property access) 114

jgloss/ui/gloss/ImportStrategy.java

Violation Line
A method/constructor shouldnt explicitly throw java.lang.Exception 64
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 79
Potential violation of Law of Demeter (static property access) 81–83
Potential violation of Law of Demeter (method chain calls) 81–85
Potential violation of Law of Demeter (method chain calls) 81–83
Potential violation of Law of Demeter (method chain calls) 82
Potential violation of Law of Demeter (object not created locally) 82
Potential violation of Law of Demeter (object not created locally) 83
Potential violation of Law of Demeter (static property access) 84

jgloss/ui/gloss/JGlossFrame.java

Violation Line
Possible God class (WMC=127, ATFD=255, TCC=0.03361344537815126) 23–1254
Too many fields 127–1254
The class 'JGlossFrame' has a Standard Cyclomatic Complexity of 4 (Highest = 17). 127–1254
The class 'JGlossFrame' has a Modified Cyclomatic Complexity of 4 (Highest = 17). 127–1254
Avoid really long classes. 127–1254
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 159
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 161
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 167
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 172
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 178
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 182
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 186
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 190
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 194
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 198
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 199
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 200
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 201
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 202
Perhaps 'hyperlinker' could be replaced by a local variable. 203
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 203
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 209
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 211
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 212
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 214
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 219
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 224
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 228
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 232
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 236
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 240
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 244
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 248
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 253
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 257
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 261
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 265
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 269
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 273
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 278
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 282
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 287
Avoid using implementation types like 'LinkedList'; use the interface instead 287
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 297–299
Potential violation of Law of Demeter (static property access) 329
Potential violation of Law of Demeter (static property access) 330
Potential violation of Law of Demeter (static property access) 334
Potential violation of Law of Demeter (static property access) 335
The method 'initActions' has a Modified Cyclomatic Complexity of 15. 441–546
The method 'initActions' has a Standard Cyclomatic Complexity of 15. 441–546
Avoid really long methods. 441–546
Potential violation of Law of Demeter (method chain calls) 507
Potential violation of Law of Demeter (static property access) 513
Potential violation of Law of Demeter (static property access) 514
Potential violation of Law of Demeter (object not created locally) 518
Potential violation of Law of Demeter (method chain calls) 518
Potential violation of Law of Demeter (method chain calls) 530
Potential violation of Law of Demeter (object not created locally) 532
Potential violation of Law of Demeter (object not created locally) 535
Potential violation of Law of Demeter (object not created locally) 538
Potential violation of Law of Demeter (method chain calls) 539
Potential violation of Law of Demeter (static property access) 562
Potential violation of Law of Demeter (object not created locally) 564
Unnecessary use of fully qualified name 'UIUtilities.createMenuItem' due to existing import 'jgloss.ui.util.UIUtilities' 564
Potential violation of Law of Demeter (object not created locally) 565
Potential violation of Law of Demeter (object not created locally) 569
Unnecessary use of fully qualified name 'UIUtilities.createMenuItem' due to existing import 'jgloss.ui.util.UIUtilities' 570
Potential violation of Law of Demeter (object not created locally) 571
Potential violation of Law of Demeter (static property access) 576
Potential violation of Law of Demeter (static property access) 577
Potential violation of Law of Demeter (static property access) 578
Potential violation of Law of Demeter (static property access) 580–581
Potential violation of Law of Demeter (static property access) 582–583
Potential violation of Law of Demeter (static property access) 584
Potential violation of Law of Demeter (static property access) 586–587
Potential violation of Law of Demeter (static property access) 588–589
Potential violation of Law of Demeter (static property access) 590
Potential violation of Law of Demeter (static property access) 593
Potential violation of Law of Demeter (static property access) 603
Potential violation of Law of Demeter (object not created locally) 604
Unnecessary use of fully qualified name 'UIUtilities.createMenuItem' due to existing import 'jgloss.ui.util.UIUtilities' 604
Potential violation of Law of Demeter (object not created locally) 605
Unnecessary use of fully qualified name 'UIUtilities.createMenuItem' due to existing import 'jgloss.ui.util.UIUtilities' 605
Potential violation of Law of Demeter (object not created locally) 606
Unnecessary use of fully qualified name 'UIUtilities.createMenuItem' due to existing import 'jgloss.ui.util.UIUtilities' 606
Potential violation of Law of Demeter (object not created locally) 607
Potential violation of Law of Demeter (object not created locally) 609
Unnecessary use of fully qualified name 'UIUtilities.createMenuItem' due to existing import 'jgloss.ui.util.UIUtilities' 610
Potential violation of Law of Demeter (object not created locally) 610
Unnecessary use of fully qualified name 'UIUtilities.createMenuItem' due to existing import 'jgloss.ui.util.UIUtilities' 611
Potential violation of Law of Demeter (object not created locally) 611
Unnecessary use of fully qualified name 'UIUtilities.createMenuItem' due to existing import 'jgloss.ui.util.UIUtilities' 612
Potential violation of Law of Demeter (object not created locally) 612
Potential violation of Law of Demeter (object not created locally) 613
Unnecessary use of fully qualified name 'UIUtilities.createMenuItem' due to existing import 'jgloss.ui.util.UIUtilities' 614
Potential violation of Law of Demeter (object not created locally) 615
Potential violation of Law of Demeter (static property access) 620
Unnecessary use of fully qualified name 'UIUtilities.createMenuItem' due to existing import 'jgloss.ui.util.UIUtilities' 621
Unnecessary use of fully qualified name 'UIUtilities.createMenuItem' due to existing import 'jgloss.ui.util.UIUtilities' 622
Unnecessary use of fully qualified name 'UIUtilities.createMenuItem' due to existing import 'jgloss.ui.util.UIUtilities' 625
Unnecessary use of fully qualified name 'UIUtilities.createMenuItem' due to existing import 'jgloss.ui.util.UIUtilities' 629
Unnecessary use of fully qualified name 'UIUtilities.createMenuItem' due to existing import 'jgloss.ui.util.UIUtilities' 630
Potential violation of Law of Demeter (static property access) 632
Potential violation of Law of Demeter (method chain calls) 632
Potential violation of Law of Demeter (method chain calls) 632
Unnecessary use of fully qualified name 'UIUtilities.createMenuItem' due to existing import 'jgloss.ui.util.UIUtilities' 635
Unnecessary use of fully qualified name 'UIUtilities.createMenuItem' due to existing import 'jgloss.ui.util.UIUtilities' 637
Potential violation of Law of Demeter (static property access) 656
Potential violation of Law of Demeter (static property access) 658
Potential violation of Law of Demeter (static property access) 659
Potential violation of Law of Demeter (static property access) 660
Potential violation of Law of Demeter (static property access) 661
Potential violation of Law of Demeter (static property access) 694–695
Potential violation of Law of Demeter (static property access) 699
Potential violation of Law of Demeter (method chain calls) 702
Potential violation of Law of Demeter (method chain calls) 702
Potential violation of Law of Demeter (static property access) 720
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 727
Potential violation of Law of Demeter (method chain calls) 728
Potential violation of Law of Demeter (static property access) 738–739
Potential violation of Law of Demeter (method chain calls) 742
Potential violation of Law of Demeter (method chain calls) 742
Potential violation of Law of Demeter (method chain calls) 743
Potential violation of Law of Demeter (method chain calls) 744
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 749
Potential violation of Law of Demeter (object not created locally) 763
Potential violation of Law of Demeter (method chain calls) 763
Potential violation of Law of Demeter (object not created locally) 771
Potential violation of Law of Demeter (method chain calls) 778
Potential violation of Law of Demeter (method chain calls) 779
Potential violation of Law of Demeter (method chain calls) 785
Potential violation of Law of Demeter (method chain calls) 786
Potential violation of Law of Demeter (method chain calls) 787
Potential violation of Law of Demeter (object not created locally) 813
Potential violation of Law of Demeter (object not created locally) 815
Potential violation of Law of Demeter (object not created locally) 820
Potential violation of Law of Demeter (object not created locally) 823
Potential violation of Law of Demeter (object not created locally) 837
Potential violation of Law of Demeter (object not created locally) 838
Potential violation of Law of Demeter (static property access) 853
Potential violation of Law of Demeter (method chain calls) 856
Potential violation of Law of Demeter (method chain calls) 856
Potential violation of Law of Demeter (static property access) 856
Potential violation of Law of Demeter (static property access) 859
Potential violation of Law of Demeter (method chain calls) 862–863
Potential violation of Law of Demeter (method chain calls) 862–863
Potential violation of Law of Demeter (static property access) 863
Potential violation of Law of Demeter (static property access) 866
Potential violation of Law of Demeter (method chain calls) 875
Potential violation of Law of Demeter (method chain calls) 876
Potential violation of Law of Demeter (method chain calls) 877
Avoid unused method parameters such as 'refKey'. 882
Potential violation of Law of Demeter (method chain calls) 890–891
Potential violation of Law of Demeter (object not created locally) 895
Potential violation of Law of Demeter (object not created locally) 897
Potential violation of Law of Demeter (object not created locally) 898
Potential violation of Law of Demeter (object not created locally) 901
Potential violation of Law of Demeter (object not created locally) 915
Potential violation of Law of Demeter (method chain calls) 954–955
Potential violation of Law of Demeter (object not created locally) 956
Potential violation of Law of Demeter (method chain calls) 960
Potential violation of Law of Demeter (method chain calls) 961
The method 'doPrint' has a Standard Cyclomatic Complexity of 17. 969–1095
Avoid really long methods. 969–1095
The method 'doPrint' has a Modified Cyclomatic Complexity of 17. 969–1095
Potential violation of Law of Demeter (object not created locally) 974
Potential violation of Law of Demeter (method chain calls) 975–976
Potential violation of Law of Demeter (object not created locally) 981
Potential violation of Law of Demeter (method chain calls) 983
Potential violation of Law of Demeter (method chain calls) 986
Potential violation of Law of Demeter (method chain calls) 986
Potential violation of Law of Demeter (method chain calls) 989
Potential violation of Law of Demeter (method chain calls) 989
Potential violation of Law of Demeter (method chain calls) 991
Potential violation of Law of Demeter (object not created locally) 992
Potential violation of Law of Demeter (object not created locally) 996
Potential violation of Law of Demeter (method chain calls) 996
Potential violation of Law of Demeter (object not created locally) 997
Potential violation of Law of Demeter (object not created locally) 998
Potential violation of Law of Demeter (object not created locally) 1000
Potential violation of Law of Demeter (object not created locally) 1008
Potential violation of Law of Demeter (object not created locally) 1009
Potential violation of Law of Demeter (object not created locally) 1010
Potential violation of Law of Demeter (object not created locally) 1019
Potential violation of Law of Demeter (object not created locally) 1032
Potential violation of Law of Demeter (object not created locally) 1065
Potential violation of Law of Demeter (object not created locally) 1067
Potential violation of Law of Demeter (object not created locally) 1068
Potential violation of Law of Demeter (object not created locally) 1083
Potential violation of Law of Demeter (object not created locally) 1090
Potential violation of Law of Demeter (method chain calls) 1091
Potential violation of Law of Demeter (method chain calls) 1106–1107
Potential violation of Law of Demeter (method chain calls) 1109
Potential violation of Law of Demeter (object not created locally) 1111
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 1115
Potential violation of Law of Demeter (object not created locally) 1116
Potential violation of Law of Demeter (object not created locally) 1120
Potential violation of Law of Demeter (method chain calls) 1120
Potential violation of Law of Demeter (object not created locally) 1120
Potential violation of Law of Demeter (static property access) 1121
Potential violation of Law of Demeter (method chain calls) 1134
Potential violation of Law of Demeter (method chain calls) 1144
Potential violation of Law of Demeter (method chain calls) 1144
Potential violation of Law of Demeter (method chain calls) 1145
Potential violation of Law of Demeter (method chain calls) 1145
Potential violation of Law of Demeter (method chain calls) 1146
Potential violation of Law of Demeter (method chain calls) 1146
Potential violation of Law of Demeter (method chain calls) 1146
Potential violation of Law of Demeter (method chain calls) 1171
Potential violation of Law of Demeter (object not created locally) 1173
Prefer StringBuffer over += for concatenating strings 1178
Potential violation of Law of Demeter (static property access) 1181
Potential violation of Law of Demeter (method chain calls) 1192
Potential violation of Law of Demeter (method chain calls) 1193–1195
Potential violation of Law of Demeter (method chain calls) 1194–1195
Potential violation of Law of Demeter (object not created locally) 1201
Potential violation of Law of Demeter (object not created locally) 1201
Potential violation of Law of Demeter (object not created locally) 1202
Potential violation of Law of Demeter (object not created locally) 1202
Potential violation of Law of Demeter (static property access) 1212
Potential violation of Law of Demeter (method chain calls) 1214–1215
Potential violation of Law of Demeter (method chain calls) 1214–1215
Potential violation of Law of Demeter (method chain calls) 1215
Potential violation of Law of Demeter (method chain calls) 1232

jgloss/ui/gloss/JGlossFrameModel.java

Violation Line
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_doc' is not final. 41
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_htmlDoc' is not final. 45
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_annotationListModel' is not final. 49
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_documentName' is not final. 53
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_documentPath' is not final. 57
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_documentChanged' is not final. 61

jgloss/ui/gloss/JGlossLookupFrame.java

Violation Line
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_model' is not final. 41
Potential violation of Law of Demeter (static property access) 53

jgloss/ui/gloss/OpenDocumentAction.java

Violation Line
Potential violation of Law of Demeter (method chain calls) 48
Potential violation of Law of Demeter (method chain calls) 54
Potential violation of Law of Demeter (method chain calls) 54
Potential violation of Law of Demeter (method chain calls) 54
Potential violation of Law of Demeter (method chain calls) 56
Potential violation of Law of Demeter (method chain calls) 58
Potential violation of Law of Demeter (method chain calls) 58
Potential violation of Law of Demeter (object not created locally) 58
Potential violation of Law of Demeter (static property access) 59

jgloss/ui/gloss/OpenDocumentWorker.java

Violation Line
There is log block not surrounded by if 92
Unnecessary use of fully qualified name 'Level.WARNING' due to existing import 'java.util.logging.Level' 92
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 111
Potential violation of Law of Demeter (static property access) 127
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 128
Unnecessary use of fully qualified name 'Level.SEVERE' due to existing import 'java.util.logging.Level' 129
Potential violation of Law of Demeter (method chain calls) 130–131
Potential violation of Law of Demeter (method chain calls) 130–133
Potential violation of Law of Demeter (static property access) 130–131
Potential violation of Law of Demeter (method chain calls) 131
Potential violation of Law of Demeter (static property access) 132

jgloss/ui/gloss/OpenRecentDocumentListener.java

Violation Line
Potential violation of Law of Demeter (static property access) 49
Potential violation of Law of Demeter (method chain calls) 59
Potential violation of Law of Demeter (object not created locally) 59
Potential violation of Law of Demeter (method chain calls) 59

jgloss/ui/gloss/ReadingEditor.java

Violation Line
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_title' is not final. 58
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_annotation' is not final. 82
Use equals() to compare object references. 83
Potential violation of Law of Demeter (object not created locally) 97
Potential violation of Law of Demeter (object not created locally) 98
Deeply nested if..then statements are hard to read 102–108
Potential violation of Law of Demeter (method chain calls) 123–124
Potential violation of Law of Demeter (static property access) 124
Potential violation of Law of Demeter (method chain calls) 125–126
Potential violation of Law of Demeter (object not created locally) 141
Potential violation of Law of Demeter (object not created locally) 143

jgloss/ui/html/AnnotationListSynchronizer.java

Violation Line
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_doc' is not final. 23
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_annotationModel' is not final. 23
Potential violation of Law of Demeter (method chain calls) 32
Potential violation of Law of Demeter (object not created locally) 33
Potential violation of Law of Demeter (object not created locally) 34
Potential violation of Law of Demeter (object not created locally) 37
Potential violation of Law of Demeter (object not created locally) 40
Potential violation of Law of Demeter (object not created locally) 40
Consider using varargs for methods or constructors which take an array the last parameter. 44
Potential violation of Law of Demeter (method chain calls) 51–52
Potential violation of Law of Demeter (method chain calls) 51–52
Potential violation of Law of Demeter (method chain calls) 65
Potential violation of Law of Demeter (object not created locally) 69
Potential violation of Law of Demeter (object not created locally) 71
Potential violation of Law of Demeter (object not created locally) 71
Consider using varargs for methods or constructors which take an array the last parameter. 75
Potential violation of Law of Demeter (method chain calls) 82–83
Potential violation of Law of Demeter (method chain calls) 82–83

jgloss/ui/html/AnnotationRemover.java

Violation Line
Potential violation of Law of Demeter (method chain calls) 44
Potential violation of Law of Demeter (static property access) 44

jgloss/ui/html/AnnotationTags.java

Violation Line
Potential violation of Law of Demeter (method chain calls) 85
Potential violation of Law of Demeter (method chain calls) 92
Potential violation of Law of Demeter (static property access) 131
Potential violation of Law of Demeter (static property access) 134
Potential violation of Law of Demeter (static property access) 137
Potential violation of Law of Demeter (static property access) 140
Potential violation of Law of Demeter (static property access) 143
Potential violation of Law of Demeter (static property access) 146

jgloss/ui/html/DocumentTreeWalker.java

Violation Line
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_end' is not final. 59
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_start' is not final. 59
Potential violation of Law of Demeter (object not created locally) 66

jgloss/ui/html/ElementUtil.java

Violation Line
System.out.println is used 39
System.out.println is used 41
System.out.println is used 45

jgloss/ui/html/HTMLToSAXParserAdapter.java

Violation Line
Potential violation of Law of Demeter (static property access) 68
Potential violation of Law of Demeter (static property access) 70
Potential violation of Law of Demeter (static property access) 72
Potential violation of Law of Demeter (static property access) 74
Potential violation of Law of Demeter (static property access) 76
Potential violation of Law of Demeter (static property access) 78
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_htmlDoc' is not final. 84
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_saxContentHandler' is not final. 84
Potential violation of Law of Demeter (object not created locally) 113
Avoid unused method parameters such as 'leaf'. 128
Potential violation of Law of Demeter (static property access) 156
Potential violation of Law of Demeter (object not created locally) 162
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_elementName' is not final. 206
Potential violation of Law of Demeter (object not created locally) 232
Potential violation of Law of Demeter (object not created locally) 232
Potential violation of Law of Demeter (static property access) 238
Potential violation of Law of Demeter (object not created locally) 239
Potential violation of Law of Demeter (object not created locally) 239
Potential violation of Law of Demeter (object not created locally) 254
Potential violation of Law of Demeter (method chain calls) 258–259
Potential violation of Law of Demeter (object not created locally) 260
Potential violation of Law of Demeter (method chain calls) 263–264
Potential violation of Law of Demeter (object not created locally) 265
Potential violation of Law of Demeter (method chain calls) 268–269
Potential violation of Law of Demeter (object not created locally) 270
Potential violation of Law of Demeter (object not created locally) 292
Potential violation of Law of Demeter (method chain calls) 296
Potential violation of Law of Demeter (object not created locally) 297
Potential violation of Law of Demeter (static property access) 315
Potential violation of Law of Demeter (object not created locally) 323
Potential violation of Law of Demeter (object not created locally) 326
Position literals first in String comparisons 327
Potential violation of Law of Demeter (object not created locally) 327
Potential violation of Law of Demeter (object not created locally) 329
Potential violation of Law of Demeter (object not created locally) 329
Potential violation of Law of Demeter (static property access) 342

jgloss/ui/html/JGlossEditor.java

Violation Line
Possible God class (WMC=60, ATFD=55, TCC=0.03557312252964427) 23–534
The class 'JGlossEditor' has a Modified Cyclomatic Complexity of 3 (Highest = 12). 66–534
The class 'JGlossEditor' has a Standard Cyclomatic Complexity of 3 (Highest = 12). 66–534
Potential violation of Law of Demeter (method chain calls) 88
Potential violation of Law of Demeter (method chain calls) 88
Potential violation of Law of Demeter (static property access) 91
Potential violation of Law of Demeter (method chain calls) 114
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 197
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 199
Avoid using redundant field initializer for 'highlightTag' 203
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 203
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 207
Perhaps 'selectAnnotationListener' could be replaced by a local variable. 211
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 211
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 216
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 220
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 224
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 228
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 233
Perhaps 'findAction' could be replaced by a local variable. 233
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 237
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 241
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 245
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 250
The constructor 'JGlossEditor' has a Standard Cyclomatic Complexity of 12. 266–351
The constructor 'JGlossEditor' has a Modified Cyclomatic Complexity of 12. 266–351
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_annotationList' is not final. 266
Potential violation of Law of Demeter (method chain calls) 297
Potential violation of Law of Demeter (method chain calls) 309–313
Potential violation of Law of Demeter (method chain calls) 310
Potential violation of Law of Demeter (static property access) 311
Potential violation of Law of Demeter (static property access) 312
Potential violation of Law of Demeter (object not created locally) 315
Potential violation of Law of Demeter (object not created locally) 316
Potential violation of Law of Demeter (method chain calls) 374
Potential violation of Law of Demeter (method chain calls) 378
Potential violation of Law of Demeter (object not created locally) 380
Potential violation of Law of Demeter (method chain calls) 389
Potential violation of Law of Demeter (method chain calls) 412
Consider simply returning the value vs storing it in local variable 'annoIndex' 413
Potential violation of Law of Demeter (method chain calls) 420
Potential violation of Law of Demeter (method chain calls) 420
Potential violation of Law of Demeter (object not created locally) 421
Potential violation of Law of Demeter (method chain calls) 442
Potential violation of Law of Demeter (method chain calls) 452
Potential violation of Law of Demeter (method chain calls) 496
Potential violation of Law of Demeter (method chain calls) 496
Potential violation of Law of Demeter (method chain calls) 496
Potential violation of Law of Demeter (method chain calls) 529

jgloss/ui/html/JGlossEditorKit.java

Violation Line
Possible God class (WMC=85, ATFD=66, TCC=0.07602339181286549) 23–830
Field showReading has the same name as a method 92
Field showTranslation has the same name as a method 96
Avoid using redundant field initializer for 'dtd' 114
Avoid using redundant field initializer for 'jglossStyleSheet' 119
The class 'JGlossFactory' has a Standard Cyclomatic Complexity of 6 (Highest = 10). 124–176
The class 'JGlossFactory' has a Modified Cyclomatic Complexity of 6 (Highest = 10). 124–176
Avoid unnecessary constructors - the compiler will generate these for you 129–130
The method 'create' has a Standard Cyclomatic Complexity of 10. 140–175
The method 'create' has a Modified Cyclomatic Complexity of 10. 140–175
Potential violation of Law of Demeter (method chain calls) 141
Potential violation of Law of Demeter (object not created locally) 143
Potential violation of Law of Demeter (object not created locally) 149
Potential violation of Law of Demeter (object not created locally) 151
Potential violation of Law of Demeter (object not created locally) 153
Potential violation of Law of Demeter (object not created locally) 153
Potential violation of Law of Demeter (static property access) 153
Potential violation of Law of Demeter (object not created locally) 155
Potential violation of Law of Demeter (object not created locally) 155
Potential violation of Law of Demeter (static property access) 155
Potential violation of Law of Demeter (object not created locally) 157
Potential violation of Law of Demeter (object not created locally) 157
Potential violation of Law of Demeter (static property access) 157
Potential violation of Law of Demeter (object not created locally) 165
Avoid using redundant field initializer for 'logicalViewParent' 187
Potential violation of Law of Demeter (method chain calls) 234
Potential violation of Law of Demeter (method chain calls) 234
These nested if statements could be combined 234–236
These nested if statements could be combined 283–285
Potential violation of Law of Demeter (method chain calls) 284
Potential violation of Law of Demeter (method chain calls) 455
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_showTranslation' is not final. 598
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_showReading' is not final. 598
Potential violation of Law of Demeter (static property access) 635
Consider simply returning the value vs storing it in local variable 'doc' 661
Singleton is not thread safe 690–770
Potential violation of Law of Demeter (static property access) 700
Potential violation of Law of Demeter (method chain calls) 708
Potential violation of Law of Demeter (method chain calls) 710
Potential violation of Law of Demeter (static property access) 719
Potential violation of Law of Demeter (static property access) 721
Potential violation of Law of Demeter (static property access) 723
Potential violation of Law of Demeter (static property access) 725
Potential violation of Law of Demeter (static property access) 726
Potential violation of Law of Demeter (static property access) 727
Potential violation of Law of Demeter (static property access) 739
Potential violation of Law of Demeter (static property access) 741
Potential violation of Law of Demeter (static property access) 742
Potential violation of Law of Demeter (static property access) 745
Potential violation of Law of Demeter (static property access) 746
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'reading_base' is not final. 747
Potential violation of Law of Demeter (static property access) 747–748
Use equals() to compare object references. 762
Use equals() to compare object references. 762
Use equals() to compare object references. 762
Use equals() to compare object references. 762
Use equals() to compare object references. 762
Use equals() to compare object references. 763
Unnecessary use of fully qualified name 'java.io.IOException' due to existing import 'java.io.IOException' 767
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_jglossStyleSheet' is not final. 810
Potential violation of Law of Demeter (method chain calls) 819

jgloss/ui/html/JGlossHTMLDoc.java

Violation Line
Possible God class (WMC=75, ATFD=87, TCC=0.016091954022988506) 23–716
An Interface should be used only to model a behaviour; consider converting this to a class. 71–93
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 95
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 97
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 99
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 101
Perhaps 'jglossDocTransformer' could be replaced by a local variable. 103
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 103
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 104
Perhaps 'docTransformTarget' could be replaced by a local variable. 104
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 109
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 111
Potential violation of Law of Demeter (method chain calls) 119–120
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 132
There is log block not surrounded by if 263
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_htmlparser' is not final. 276
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_styles' is not final. 276
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_baseDoc' is not final. 286
Potential violation of Law of Demeter (method chain calls) 383
Potential violation of Law of Demeter (method chain calls) 402
Potential violation of Law of Demeter (object not created locally) 435
Potential violation of Law of Demeter (object not created locally) 460
Potential violation of Law of Demeter (method chain calls) 461–462
Potential violation of Law of Demeter (object not created locally) 461–462
Potential violation of Law of Demeter (method chain calls) 461–462
Potential violation of Law of Demeter (object not created locally) 463
Potential violation of Law of Demeter (object not created locally) 463
Potential violation of Law of Demeter (object not created locally) 467
Potential violation of Law of Demeter (object not created locally) 476
Potential violation of Law of Demeter (object not created locally) 477–478
Potential violation of Law of Demeter (method chain calls) 477–478
Potential violation of Law of Demeter (method chain calls) 477–478
Potential violation of Law of Demeter (object not created locally) 479
Potential violation of Law of Demeter (object not created locally) 479
Potential violation of Law of Demeter (object not created locally) 482
Potential violation of Law of Demeter (object not created locally) 504
Potential violation of Law of Demeter (object not created locally) 519
Potential violation of Law of Demeter (object not created locally) 521
Potential violation of Law of Demeter (object not created locally) 526
Potential violation of Law of Demeter (object not created locally) 530
Potential violation of Law of Demeter (object not created locally) 537
Potential violation of Law of Demeter (object not created locally) 542
Potential violation of Law of Demeter (object not created locally) 546
Potential violation of Law of Demeter (object not created locally) 550
Potential violation of Law of Demeter (object not created locally) 550
Potential violation of Law of Demeter (object not created locally) 550
Potential violation of Law of Demeter (object not created locally) 560
Potential violation of Law of Demeter (object not created locally) 560
Potential violation of Law of Demeter (object not created locally) 564
Potential violation of Law of Demeter (object not created locally) 569
Potential violation of Law of Demeter (object not created locally) 572
Potential violation of Law of Demeter (object not created locally) 575
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 577
Potential violation of Law of Demeter (object not created locally) 578
Potential violation of Law of Demeter (object not created locally) 598
Potential violation of Law of Demeter (object not created locally) 602
Potential violation of Law of Demeter (object not created locally) 612
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 694

jgloss/ui/html/JGlossParser.java

Violation Line
There is log block not surrounded by if 110

jgloss/ui/html/JGlossTagElement.java

Violation Line
Overridable method 'getHTMLTag' called during object construction 48

jgloss/ui/html/SAXToHTMLParserAdapter.java

Violation Line
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_htmlHandler' is not final. 47
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_dtd' is not final. 48
Potential violation of Law of Demeter (method chain calls) 86
Potential violation of Law of Demeter (method chain calls) 97

jgloss/ui/html/SelectedAnnotationHighlighter.java

Violation Line
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_editor' is not final. 18
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_list' is not final. 18
Potential violation of Law of Demeter (object not created locally) 35
Potential violation of Law of Demeter (object not created locally) 36
Potential violation of Law of Demeter (object not created locally) 40
Potential violation of Law of Demeter (object not created locally) 41
Potential violation of Law of Demeter (object not created locally) 41

jgloss/ui/html/TextElement.java

Violation Line
Avoid using redundant field initializer for 'text' 39
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_element' is not final. 41
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_text' is not final. 57
Potential violation of Law of Demeter (object not created locally) 68
Potential violation of Law of Demeter (object not created locally) 70
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 71
Potential violation of Law of Demeter (object not created locally) 72
Potential violation of Law of Demeter (method chain calls) 95–96
Potential violation of Law of Demeter (object not created locally) 97
Potential violation of Law of Demeter (object not created locally) 101

jgloss/ui/html/UnannotatedTextFetcher.java

Violation Line
StringBuffers can grow quite a lot, and so may become a source of memory leak (if the owning class has a long life time). 41
Potential violation of Law of Demeter (static property access) 66
Potential violation of Law of Demeter (method chain calls) 66
Potential violation of Law of Demeter (static property access) 70
Potential violation of Law of Demeter (method chain calls) 70
Potential violation of Law of Demeter (object not created locally) 81
Potential violation of Law of Demeter (object not created locally) 82

jgloss/ui/welcome/DictionaryDownloadPage.java

Violation Line
Potential violation of Law of Demeter (method chain calls) 62
Potential violation of Law of Demeter (method chain calls) 62
Potential violation of Law of Demeter (method chain calls) 62
Potential violation of Law of Demeter (method chain calls) 62
Potential violation of Law of Demeter (static property access) 67

jgloss/ui/welcome/FinishPage.java

Violation Line
Potential violation of Law of Demeter (static property access) 42

jgloss/ui/welcome/ImportPage.java

Violation Line
Potential violation of Law of Demeter (static property access) 91
Potential violation of Law of Demeter (method chain calls) 97–98
Potential violation of Law of Demeter (method chain calls) 98
Potential violation of Law of Demeter (method chain calls) 103
Potential violation of Law of Demeter (method chain calls) 103

jgloss/ui/welcome/WelcomeDialog.java

Violation Line
Potential violation of Law of Demeter (static property access) 86

jgloss/ui/welcome/WelcomePage.java

Violation Line
Potential violation of Law of Demeter (static property access) 42

jgloss/ui/wizard/ButtonBar.java

Violation Line
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 63
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 65
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 67
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 69
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 71
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 73
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 75
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 77
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 79
Potential violation of Law of Demeter (object not created locally) 133
Potential violation of Law of Demeter (method chain calls) 137
Potential violation of Law of Demeter (method chain calls) 141

jgloss/ui/wizard/Wizard.java

Violation Line
Switch statements should have a default label 44–56
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 60
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 62
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 64
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 66
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 68
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 70
Potential violation of Law of Demeter (method chain calls) 76
Potential violation of Law of Demeter (method chain calls) 76
Consider using varargs for methods or constructors which take an array the last parameter. 80

jgloss/ui/wizard/WizardPage.java

Violation Line
An empty method in an abstract class should be abstract instead 56–57

jgloss/ui/wizard/WizardPageContainer.java

Violation Line
Potential violation of Law of Demeter (method chain calls) 60

jgloss/ui/xml/AnnotationGenerator.java

Violation Line
The class 'AnnotationGenerator' has a Modified Cyclomatic Complexity of 2 (Highest = 14). 59–316
The class 'AnnotationGenerator' has a Standard Cyclomatic Complexity of 2 (Highest = 14). 59–316
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_parent' is not final. 77
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_readingFilter' is not final. 77
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_parser' is not final. 78
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_dictionaries' is not final. 78
Consider using varargs for methods or constructors which take an array the last parameter. 78
Potential violation of Law of Demeter (object not created locally) 165
Potential violation of Law of Demeter (object not created locally) 166
Potential violation of Law of Demeter (object not created locally) 168
Potential violation of Law of Demeter (object not created locally) 168
The method 'createAnnotationElement' has a Standard Cyclomatic Complexity of 14. 179–258
The method 'createAnnotationElement' has a Modified Cyclomatic Complexity of 14. 179–258
There is log block not surrounded by if 203
Avoid using Literals in Conditional Statements 214
Avoid using Literals in Conditional Statements 234
Potential violation of Law of Demeter (method chain calls) 239
Potential violation of Law of Demeter (method chain calls) 239
Potential violation of Law of Demeter (method chain calls) 239
Potential violation of Law of Demeter (method chain calls) 247
Potential violation of Law of Demeter (method chain calls) 247
Potential violation of Law of Demeter (method chain calls) 247
Potential violation of Law of Demeter (method chain calls) 247
Potential violation of Law of Demeter (method chain calls) 248
Potential violation of Law of Demeter (method chain calls) 248
Avoid using Literals in Conditional Statements 250
Avoid printStackTrace(); use a logger call instead. 291
Avoid printStackTrace(); use a logger call instead. 296
Rather than using a lot of String arguments, consider using a container object for those values. 311–312

jgloss/ui/xml/CloseMetaTagInputStream.java

Violation Line
The class 'CloseMetaTagInputStream' has a Standard Cyclomatic Complexity of 4 (Highest = 12). 14–97
StringBuffers can grow quite a lot, and so may become a source of memory leak (if the owning class has a long life time). 25
The method 'read' has a Standard Cyclomatic Complexity of 12. 34–80
Switch statements should have a default label 43–76
Avoid using Literals in Conditional Statements 45
Avoid using Literals in Conditional Statements 71

jgloss/ui/xml/DocumentGenerator.java

Violation Line
Potential violation of Law of Demeter (object not created locally) 86
Potential violation of Law of Demeter (static property access) 111
Potential violation of Law of Demeter (method chain calls) 112–113
Potential violation of Law of Demeter (method chain calls) 112–113

jgloss/ui/xml/JGloss1Converter.java

Violation Line
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 49
Avoid prefixing parameters by in, out or inOut. Uses Javadoc to document this behavior. 61
Avoid prefixing parameters by in, out or inOut. Uses Javadoc to document this behavior. 119

jgloss/ui/xml/JGlossDocument.java

Violation Line
An Interface should be used only to model a behaviour; consider converting this to a class. 42–53
An Interface should be used only to model a behaviour; consider converting this to a class. 55–62
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 64
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 66
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 67
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 68
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 70
Variables that are final and static should be all capitals, 'docFactory' is not all capitals. 70
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 80
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 81
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_in' is not final. 83
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_in' is not final. 87
Potential violation of Law of Demeter (method chain calls) 89
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_doc' is not final. 96
Use block level rather than method level synchronization 100–106
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_doc' is not final. 108
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_htmlDoc' is not final. 112
Use block level rather than method level synchronization 131–133
Use block level rather than method level synchronization 135–143

jgloss/ui/xml/JGlossDocumentBuilder.java

Violation Line
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 55
Consider using varargs for methods or constructors which take an array the last parameter. 64
Consider simply returning the value vs storing it in local variable 'result' 74

jgloss/ui/xml/JGlossifyReader.java

Violation Line
The class 'JGlossifyReader' has a Standard Cyclomatic Complexity of 4 (Highest = 16). 44–394
The class 'JGlossifyReader' has a Modified Cyclomatic Complexity of 4 (Highest = 16). 44–394
Avoid using redundant field initializer for 'eof' 64
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 154
StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. 159
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 159
The method 'read' has a Modified Cyclomatic Complexity of 16. 167–264
The method 'read' has a Standard Cyclomatic Complexity of 16. 167–264
Potential violation of Law of Demeter (object not created locally) 190
Potential violation of Law of Demeter (object not created locally) 194
Potential violation of Law of Demeter (object not created locally) 197
Potential violation of Law of Demeter (object not created locally) 198
These nested if statements could be combined 209–221
Deeply nested if..then statements are hard to read 213–219
Potential violation of Law of Demeter (method chain calls) 218
Potential violation of Law of Demeter (method chain calls) 252
Potential violation of Law of Demeter (method chain calls) 286
Potential violation of Law of Demeter (method chain calls) 286
Avoid prefixing parameters by in, out or inOut. Uses Javadoc to document this behavior. 295
Avoid using Literals in Conditional Statements 319
Avoid using Literals in Conditional Statements 322
Potential violation of Law of Demeter (method chain calls) 327
Returning 'singleChar' may expose an internal array. 390